Updated Binaries December 2023 #361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LLama/Native/LLamaKvCacheView.cs
Outdated
| /// </summary> | ||
| /// <param name="view"></param> | ||
| [DllImport(libraryName, CallingConvention = CallingConvention.Cdecl)] | ||
| public static extern unsafe void llama_kv_cache_view_free(LLamaKvCacheView* view); |
There was a problem hiding this comment.
This is an amazing feature!
- Renamed `LLamaModelKvOverride` to `LLamaModelMetadataOverride`
martindevans
force-pushed
the
update_binaries_dec_2023
branch
from
bc095e6 to
b868b05
Compare
…broken (converter is never called)
|
Ok this is ready for review now. The CI has run tests for Windows, Linux and Mac (x64). Just MacOS ARM left! |
|
Some discussion about this in #350, which might end up being merged into this PR. If you'd rather not wait, we can merge this PR and put out a release right away. The cudart stuff can be added in a patch update at any time. |
|
If it's convenient for you, then feel free to do so. :) |
|
It's checked on OSX-ARM. It's Ok for me. |
|
Thanks for testing that @SignalRT. I think I'll merge this one now, cudart stuff can come in a later PR. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This build includes AVX and AVX2 for MacOS x86_64. If anyone has an Intel Mac testing would be much appreciated!
Todo:
MetadataOverrideTesting: